Add a new support document as a landing page for URLs in old support …#1264
Add a new support document as a landing page for URLs in old support …#1264
Conversation
content/new-web-infrastructure.md
Outdated
|
|
||
| --- | ||
|
|
||
| <!-- |
There was a problem hiding this comment.
This does not seem to be a standard footer for all of the articles. Versioning and authorship information are already tracked via Git. Having it in the article's text adds an additional maintenance burden. Do we need to have this here?
There was a problem hiding this comment.
I think it's good to keep. If this content moves to odoo, we would loose the github tracking for credit
There was a problem hiding this comment.
If the support site is migrated to Odoo, "credit" can be added at that time if it's needed. Nothing from the git history will be "lost" until all copies of the repository are deleted.
I still don't see why it would be needed even if that were the case-- we've had this discussion before regarding sticking names at the bottom of articles, and come away not recognizing it as necessary (ditto for doc version, and also for date, which we have an entire plugin installed just to present on the current live site).
There was a problem hiding this comment.
I've gone ahead and removed it. I want to reiterate, you guys can add that stuff back if & when the docs are migrated to another platform. For now, authorship & date/version info are not only tracked in git but are presented at the bottom of the page by our Nuxt plugins/config.
|
Updated to respond to comments. Waiting on lint checks to pass. |
burden
left a comment
burden
left a comment
There was a problem hiding this comment.
URL has changed. The old URL redirects. No worries if you don't want to update November tho.
|
@thomas-zimmerman Did you skip the four comments that GitHub hid by default on purpose, or did you not notice they were there? It doesn't look like they've been addressed. You can disagree with them if you'd like, but I wanted to make sure.
|
|
No, that was me missing them in the github UI; I'll take a look and make sure to address them tomorrow. |
|
...and should have update for all of the outstanding bits here. |
burden
left a comment
burden
left a comment
There was a problem hiding this comment.
lgtm
@jacobgkau what do you think?
…messages to allow both an explnation and quick way to open support ticket if they still need help.
jacobgkau
force-pushed
the
new-web-infrastructure-landing
branch
from
c140767 to
7f6c018
Compare
jacobgkau
left a comment
jacobgkau
left a comment
There was a problem hiding this comment.
Sorry, didn't realize this had been waiting on me. I made a few more tweaks. The current version is acceptable from my perspective as QA.
ahoneybun
left a comment
ahoneybun
left a comment
There was a problem hiding this comment.
LGTM minus that one note about the hidden value.
| facebookImage: /_social/article | ||
| twitterImage: /_social/article | ||
|
|
||
| hidden: true |
There was a problem hiding this comment.
I suspect this is on purpose?
There was a problem hiding this comment.
I think that's so it doesn't show up in the list, since it's meant as a landing page and isn't necessarily useful to be browsed.
There was a problem hiding this comment.
That's what I was thinking so this PR is good then.
5 participants
…messages to allow both an explanation
and quick way to open support ticket if they still need help.
@burden I would like to have the redirect for https://system76.com/my-account/ticket/# to land on this support article.
I would like to have some additional eyes on the language as I've got this pretty bare bones at the moment.